fix(a11y): improve non-text (border) colour contrast#1625
fix(a11y): improve non-text (border) colour contrast#1625
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
I think we definitely need to work on the contrast and visibility of inputs and buttons (and all interactive elements). But I don't think we need to extend this to the entire interface. Unfortunately, I can't understand the wording of their expectations for background elements:
Now the interface looks like a terminal from the 2000s or, as some would say, like a tech newspaper... How about to add a |
A step towards resolving #1510, but it does have a wide effect on a lot of components (e.g. search boxes, buttons, etc.) that would be failing (and causes them to pass).
As stated in #1510, we are currently failing WCAG 2.2 SC 1.4.11 (Level AA) which requires a minimum non-text colour ratio of 3:1 for user interface components and graphical objects. This was most notable for the search field and buttons.
This PR increases the lightness channels of the
--borderand--border-hovervalues for the light and dark colour schemes which in effect causes their contrast on the main background to just pass 3:1. The original issue did include the ratios of the borders and the inner surface (i.e. the background colour of the component itself). For buttons, I don’t think this is necessary. For text fields, this maybe necessary unless there are other visual elements within the border (e.g. our main search field has the leading./).Admittedly, just increasing the border contrast alone isn’t a great design decision. Adding other visual effects could help, but it would be a bit of a departure from the current design paradigm. There’s also the issue of pairing these border colours with different background colours—there could be failures.
#262626/#101010)#636363/#101010)#CECECE/#FFFFFF)#949494/#FFFFFF)Full page comparison of home and package views
Ignore other non-border-contrast visual differences. I’ve got screenshots of different builds. This is tedious work.